]> dgit.raspbian.org Git - gnome-shell.git/commit
switcherPopup: Fix switch-group mouse click regression
authorHåkon Hægland <hakon.hagland@gmail.com>
Tue, 11 Nov 2025 18:46:32 +0000 (19:46 +0100)
committerHåkon Hægland <hakon.hagland@gmail.com>
Tue, 11 Nov 2025 18:46:32 +0000 (19:46 +0100)
commit811364ae59340195aa1c9c3edcc0d784d39105c2
treef4a8d9b9da3fe4c33739987be47b9d39242c025e
parent53bf921bd398d824116441ebd3fa12129cb1eb9b
switcherPopup: Fix switch-group mouse click regression

The LongPressGesture 'may-recognize' callback in commit 314137c8c was
checking if clicks were inside '_switcherList', but thumbnails shown by
switch-group are siblings of _switcherList, not children.

This caused the gesture to incorrectly identify thumbnail clicks as
'outside' clicks, closing the popup before the click could complete.

Fix by adding a _isActorOutside() helper method that subclasses can
override to check additional containers. AppSwitcherPopup now properly
checks both _switcherList and _thumbnails.

Tested on Ubuntu 25.10 with GNOME Shell 49.0. Confirmed:
- switch-group mouse clicks now work
- switch-applications and switch-windows unaffected
- clicking outside the popup still closes it correctly
- no regressions introduced

Fixes: 314137c8c9 ("switcherPopup: Move to a ClutterGesture for closing the popup")
Closes: https://gitlab.gnome.org/GNOME/gnome-shell/-/issues/8812
Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/3959>
js/ui/altTab.js
js/ui/switcherPopup.js